-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not prevent single-read or single-write above rate limit #4
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a single read or write exceeds the amount specified in the rate limit, then nothing stops that read or write from exceeding the rate limit.
For example, if I set rate limit to 1KB/s, and I
Write
a 2KB[]byte
, then the full 2KB will be written immediately.I think this library should try to measure the incoming read or write sizes and buffer them out to achieve the rate limit.
The text was updated successfully, but these errors were encountered: