Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshmallow-jsonschema on conda-forge #153

Open
k-dominik opened this issue Jun 21, 2021 · 4 comments
Open

marshmallow-jsonschema on conda-forge #153

k-dominik opened this issue Jun 21, 2021 · 4 comments

Comments

@k-dominik
Copy link

Dear @fuhrysteve (and all others who identify as owners of this wonderful library),

I would like to add marshmallow-jsonschema to the conda-forge package manager. I took the liberty of opening a PR here: conda-forge/staged-recipes#15361

Would you be okay with making the package available there?

This doesn't mean any additional work on your side, once you publish a new version on pypi, the process is almost automatic to rebuild on conda-forge. I would gladly add you, @fuhrysteve, (or anyone else you see fit) to the recipe maintainers if you want that. But I am happy maintaining it.

Cheers
Dominik

@fuhrysteve
Copy link
Owner

Looks cool! I've not used conda before, but I've got a vague understanding of what it is for. Is there anything we can do in this repo that would make packaging easier for conda? Seems like it'd be annoying to have to manage it in a separate repo every time we cut a new release - but if that's just how conda works then so be it.

Happy to help however I can and thanks so much for your contribution!

@k-dominik
Copy link
Author

Hey @fuhrysteve, that's awesome - thank you :)

Your package is in perfect condition for conda-forge, really. Most packages with pypi source are maintained like that.
Once the pull request there is accepted, there will be a new repository (conda-forge/marshmallow-jsonschema-feedstock) created. There is a bot that watches the pypi repository and it will automatically open a PR in the feedstock reposiotry whenever you release a new version with your current deployment setup.

Shall I add you as a maintainer there as well (really, totally fine if you prefer not to be bothered with that at all).

@fuhrysteve
Copy link
Owner

fuhrysteve commented Jun 21, 2021

If you add me as a maintainer I'll gladly help keep an eye out for those PRs and merge them when I see them!

@k-dominik
Copy link
Author

Done - That's really great!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants