-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Improve documentation #16
Labels
Milestone
Comments
You are probably aware of it, but just to remind you if you aren't. The example in README.md uses this class as a model: case class Resume(
@tag id: String,
@tag candidateName: String,
@tag candidateSurname: String,
@field position: String,
@field age: Option[Int],
@field rate: Double,
@timestamp created: Long
) However, a snippet from macros module reveals that Option is only supported on tag values (which can only be Strings) private val TIMESTAMP_TYPE = tpdls[Long]
private val SUPPORTED_TAGS_TYPES =
Seq(tpdls[Option[String]], tpdls[String])
final private val SUPPORTED_FIELD_TYPES =
Seq(tpdls[Boolean], tpdls[Int], tpdls[Double], tpdls[String], tpdls[Float], TIMESTAMP_TYPE) |
It would be helpful to have sample comparing to the code using @tag scala-influxdb-client since many people will be familiar with it first. Like:
etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you have any ideas, how I can improve documentation - leave notes here. Feel free to open a PR.
The text was updated successfully, but these errors were encountered: