Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support parsing commit message body #258

Open
yanang007 opened this issue Jan 9, 2023 · 0 comments
Open

[Feature] Support parsing commit message body #258

yanang007 opened this issue Jan 9, 2023 · 0 comments

Comments

@yanang007
Copy link

Hi! I really like the idea of gitmoji-changelog, but I'm recently encountering a strange situation. For example, a commit that adds a feature using APIs from a higher version of upstream and therefore drops support for older version. IMO the commit message may be something like:

:sparkles: Add new features

- :boom: Remove support for older versions

However, for now gitmoji-changelog parses only the subject of commit message, the 💥 down there will be ignored. So I'm wondering if some gitmojis can be declared to be CRITICAL that should be extracted from commit message body and then be treated just like normal subjects.

I have implemented a demo in my fork (yanang007@06ebe74) , which adds a dummy group "critical" like "useless" to mark critical gitmojis and the "critical" group will be removed before mapping gitmojis to ensure consistent behaviors. Implementing the idea like this can reuse the custom group mapping mechanism and provide more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant