Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Support #26

Open
firatkucuk opened this issue Jul 4, 2023 · 10 comments · Fixed by #27
Open

Subscription Support #26

firatkucuk opened this issue Jul 4, 2023 · 10 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@firatkucuk
Copy link
Collaborator

firatkucuk commented Jul 4, 2023

Supporting end to end graphql subscription.

@firatkucuk firatkucuk changed the title Stream Support Subscription Support Jul 4, 2023
@firatkucuk firatkucuk added the enhancement New feature or request label Jul 4, 2023
@firatkucuk firatkucuk self-assigned this Jul 4, 2023
@rollinglaughter
Copy link

When will this be published?

@Survival1sm
Copy link

I am also looking for a stitching library that supports subscriptions, has any new progress been made on this front?

@firatkucuk
Copy link
Collaborator Author

Sorry people, This took so much time than I anticipated. I am still working on it. Please subscribe to the issue for further notifications.

@firatkucuk
Copy link
Collaborator Author

Good news, MVP is completed. I am working on polishing and some stability issues. I am expecting it will be released really soon.

@firatkucuk firatkucuk linked a pull request Aug 25, 2023 that will close this issue
14 tasks
@Survival1sm
Copy link

Good news, MVP is completed. I am working on polishing and some stability issues. I am expecting it will be released really soon.

Looking forward to this release, any updates on when you expect it may happen?

@firatkucuk
Copy link
Collaborator Author

@Survival1sm I have no excuses 🙈 I was procrastinating. I have more time nowadays. I will work on it. PR is almost complete, I was working on a better API design and stability. It seems the configuration will be a little bit complex maybe I need to create a spring library for that one. Also, I want to hear from your tech stack. So I can come up with better solutions.

@Survival1sm
Copy link

@firatkucuk We are on spring cloud gateway with a mixture of rest/websocket and graphql/subscription microservices. Consul is used as our service discovery mechanism. I plan to replace graphql-orchestrator in favor of lilo in my project (https://github.com/Survival1sm/spring-cloud-gateway-graphql-lace), which leverages consul to automatically configure and expose the stitched endpoint for registered graphql services.

@firatkucuk
Copy link
Collaborator Author

Hello people, A long-awaited subscription feature has been added. 319 files changed. Subscription configuration is a little bit complex because of the framework-agnostic nature of Lilo. That's why I have created a new library lilo-spring to make it easy to use. If you want to use it on Quarkus or other web frameworks, we need to create libraries for them. Eventually, we will create but for now, the main focus is Spring.

Please try to use it. I won't close this issue until all questions related to this issue have been resolved.

@rollinglaughter
Copy link

Could you explain the purpose of the websocketwrapper class? Can we not pass the native session directly?

@firatkucuk
Copy link
Collaborator Author

@rollinglaughter, WebSocketSessionWrapper class is basically a WebSocket Session but Lilo should be framework agnostic. That's why we need an adapter class or a wrapper for framework-specific sessions. If you're using spring I strongly suggest you use the new lilo-spring library. If you are using another framework I can work on an example of your framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants