-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLED latest version fetched on every update #1197
Comments
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. |
Still an issue. |
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. |
Still an issue. |
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. |
Still an issue. |
I have no idea if this is related but today GitHub has massively throttled the download speed of a release file. After turning on my VPN (so changing my IP address), the down speed jumped from 200kb/s to so fast that the 150mb file was finished before I had time to look at the speed.. so about 50mb/s I think (max possible). Nevertheless, this issue should really get addressed to reduce the API call amount on GH servers. |
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. |
Still an issue. |
I have some WLED controllers coming in and was taking a look at the integration and this library. I decided to dig into this out of curiosity. If I am reading the code correctly the call to |
This will be addressed by #1334 In which, the WLED instance isn't doing any communication with GitHub anymore. Instead, I've separated the WLED & GitHub versioning checking, allowing Home Assistant to run a single, dedicated coordinator for getting update information without interfering with any WLED device communication. |
Fixed in this library by #1334 |
Problem/Motivation
Related to: home-assistant/core#93475
Every time the state gets updated, the update sensor in HA goes unavailable. It looks like this is caused by this library as every time this
python-wled/src/wled/wled.py
Line 236 in d2cdb35
Expected behavior
After the versions have been fetched, cache and re-use them (unless the
full_update
parameter is set toTrue
).Actual behavior
Version gets fetched again.
Steps to reproduce
Unkown
The text was updated successfully, but these errors were encountered: