Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/additional device settings #583

Closed

Conversation

phyzical
Copy link

@phyzical phyzical commented Feb 6, 2024

Looks at adding support for device specific configuration of the endpoint and keepalive values per peer.

closes #582

i got up to the logic around "addPeer" and found out its a submodule

https://github.com/search?q=repo%3AfreifunkMUC%2Fwg-embed%20addpeer&type=code

@GoliathLabs is there any pointers on how i would pin this module to a branch to perform a full end to end test of the logic? im fairly green with go

freifunkMUC/wg-embed#22

is working and changes are being reflected in the wg0 config as expected

Screenshot 2024-02-07 at 11 15 42 am

image can be tested via phyzical/wg-access-server:latest

@phyzical phyzical requested a review from a team as a code owner February 6, 2024 08:20
Copy link

mergeable bot commented Feb 6, 2024

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@phyzical phyzical marked this pull request as draft February 6, 2024 08:20
@GoliathLabs
Copy link
Member

@phyzical the easiest way would be to fork the wg-embed repository and import the forked module instead of our upstream one. That way you can test your changes. If everything works fine, you can create a PR against wg-embed and wg-access-server.

@phyzical
Copy link
Author

phyzical commented Feb 7, 2024

@GoliathLabs thx was able to jimmy rig it to work via mounting and using require, added rough docs to help others in the future

The only issue i am facing atm is that for some reason the Persistent keep alive value is not being pulled out of the database after being saved? this is a visual only bug though.

I have confirmed its in the db
image

any idea if there is something magic i have missed?
if i dump the json object returned from the api call i see its just missing?
image

@fbuetler
Copy link

fbuetler commented Feb 7, 2024

@phyzical you will also need to add it here.

@fbuetler
Copy link

fbuetler commented Feb 7, 2024

On another note, can you please revert the various format changes you did? It pollutes the PR and makes it hard to read IMO.

For reference, we need to first merge freifunkMUC/wg-embed#22, release wg-embed and update it in the go.mod.

@phyzical
Copy link
Author

phyzical commented Feb 8, 2024

@phyzical you will also need to add it here.

But this is device specific not server specific

On another note, can you please revert the various format changes you did? It pollutes the PR and makes it hard to read IMO.

@fbuetler its all auto lint conforming to this projects prettierrc i dont think i will even be able to undo those changes and still formatting anything else, it looks like if you hide whitespace in the review settings it becomes minimal again.

@phyzical
Copy link
Author

phyzical commented Feb 8, 2024

hmm i need to do more research, while this pr does let me connect two wg access-servers to each other i still cant resolve traffic between the two like i had hoped...

@phyzical phyzical closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point-To-Point vpn configuration help
3 participants