Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to build scripts if container is older than a day #516

Open
deeplow opened this issue Aug 14, 2023 · 2 comments
Open

Add warning to build scripts if container is older than a day #516

deeplow opened this issue Aug 14, 2023 · 2 comments
Labels
development Development-focused changes good first issue Good for newcomers stretch goal
Milestone

Comments

@deeplow
Copy link
Contributor

deeplow commented Aug 14, 2023

Add a heuristic to release build scripts to avoid potentially mistakenly shipping a version with an old container image (never happened but let's make sure it stays that way).

There may be better approaches to this than this simple heuristic but it would already be better than nothing.

@deeplow deeplow added the development Development-focused changes label Aug 14, 2023
@apyrgio apyrgio added this to the 0.5.0 milestone Aug 22, 2023
@apyrgio apyrgio modified the milestones: 0.5.0, 0.5.1 Aug 28, 2023
@deeplow deeplow added the good first issue Good for newcomers label Oct 19, 2023
@amnak613
Copy link
Contributor

im interested in taking this task on

@almet
Copy link
Contributor

almet commented Oct 31, 2024

Hey @amnak613 thanks for proposing to help here.

The release scripts are here:

And if you're interested, you can have a look at the https://github.com/freedomofpress/dangerzone/blob/main/BUILD.md file to get more information about how we build everything.

Just adding a warning to the scripts will be enough, I believe. Because we don't yet have a way to easily share code between the scripts (this is tracked by #946) , the code you add will likely be duplicated between the different scripts.

Don't hesitate if you have any further question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development-focused changes good first issue Good for newcomers stretch goal
Projects
None yet
Development

No branches or pull requests

4 participants