Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning: The histogram feature was deprecated... when using tsfel.time_series_features_extractor #162

Closed
GniLudio opened this issue Aug 28, 2024 · 3 comments · Fixed by #167
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GniLudio
Copy link

I get the warning

tsfel\feature_extraction\features.py:498: FutureWarning: The histogram feature was deprecated in version 0.1.8 and will be replaced by the mode of histogram in 0.1.9. From then on, only a single feature value will be returned.
  warnings.warn(

when using tsfel.time_series_features_extractor.

Note

  • On Linux the warning appears every time (not only the first time) tsfel.time_series_features_extractor is used.
    • I don't know the exact reason/difference that causes the warning to be logged multiple times.
  • I found this similar issue, but that's already closed and 5 years ago.
@dmfolgado
Copy link
Member

dmfolgado commented Aug 28, 2024

Hi @GniLudio thank you for letting us know. The warning is related to the deprecation of the current implementation of the histogram feature. We will switch to a different implementation that does not require defining the limits of the histogram (the previous version did so, and if not properly adjusted, the histogram feature could not make much sense).

We plan to release the revised histogram implementation soon and remove the warning. Out of curiosity, you mentioned that Linux appears every time. Have you also had that issue on Windows?

@GniLudio
Copy link
Author

Hi @GniLudio thank you for letting us know. The warning is related to the deprecation of the current implementation of the histogram feature. We will switch to a different implementation that does not require defining the limits of the histogram (the previous version did so, and if not properly adjusted, the histogram feature could not make much sense).

We plan to release the revised histogram implementation soon and remove the warning. Out of curiosity, you mentioned that Linux appears every time. Have you also had that issue on Windows?

On windows the warning only appears the first time.

@dmfolgado
Copy link
Member

Interesting. Thank you for letting me know.

@dmfolgado dmfolgado self-assigned this Sep 10, 2024
@dmfolgado dmfolgado added the bug Something isn't working label Sep 10, 2024
@dmfolgado dmfolgado added this to the v0.1.9 milestone Sep 10, 2024
@dmfolgado dmfolgado linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants