Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom methods of feathersjs^5? #22

Open
fratzinger opened this issue Apr 16, 2021 · 3 comments
Open

Support for custom methods of feathersjs^5? #22

fratzinger opened this issue Apr 16, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@fratzinger
Copy link
Owner

Check and prepare for tests
@fratzinger fratzinger added the enhancement New feature or request label Apr 16, 2021
@fratzinger fratzinger mentioned this issue Apr 16, 2021
Closed
@brniwllnr
Copy link

Just wanted to ask if there are any updates?
I just finished my feathersjs-v4 to v5 migration in order to properly use custom-service-methods.

Now my only problem I still have is that i'm getting an "You're not allowed to findLastMessages on 'messages'"-error.
Is there already a wait to "allow" my custom method ?

@fratzinger
Copy link
Owner Author

Not yet and I don't know when I get to working on that.

For now you can't use feathers-casl for custom method. You need to exclude the hook from your custom method and create your own authorization. Sorry for the inconvenience. I'm happy to accept PRs though.

@fratzinger
Copy link
Owner Author

@brniwllnr I have a first implementation for custom methods now. I think this fulfills your use case. I released it as [email protected]. Please checkout the example in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fratzinger @brniwllnr