Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC Generated Keys support for all databases #6795

Closed
tnleeuw opened this issue May 8, 2024 · 1 comment · Fixed by #6794 or #6825
Closed

JDBC Generated Keys support for all databases #6795

tnleeuw opened this issue May 8, 2024 · 1 comment · Fixed by #6794 or #6825
Assignees
Milestone

Comments

@tnleeuw
Copy link
Contributor

tnleeuw commented May 8, 2024

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗

Describe the issue
JDBC support for getting generated keys from the database is only partially supported. There is still code to query tables for highest key value, or special support for getting the value from sequence manually.

All this code can now be cleaned up with modern drivers.

Reporter
Tim van der Leeuw

@tnleeuw tnleeuw added this to the 8.2 milestone May 8, 2024
@tnleeuw tnleeuw self-assigned this May 8, 2024
@tnleeuw tnleeuw linked a pull request May 8, 2024 that will close this issue
@evandongen
Copy link
Contributor

Tim, I don't see how your changes are implementing what is described in the issue. Can you explain how these changes enable you to get generated keys from the database?

@nielsm5 nielsm5 reopened this May 13, 2024
@tnleeuw tnleeuw linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants