-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem with action=write and createFolder=true does not create folder #6747
Comments
Hmm strange reminds me of #5220 |
After some investigation I uncovered that the |
Thanks for the investigation, I've over-looked this.. Is this behaviour desired? Since it could create awkward situations where the given configuration seems correct but it's actually incorrect. Two ideas:
|
I don't think that the current behaviour is correct. I think it should be corrected, without adding extra configuration options, in a way that it will work for all filesystems. The |
Ready for review. See #6792 - I added Niels, Tim and Jacobjob as reviewers |
After some discussion we came to the conclusion this (using createFolder to determine whether the filesystem root needs to be created) is not the solution we need. We don't want to create a root folder automatically, since this might introduce unwanted creation of directories. For now in version 7.9.x, we recommend the following. In this case, the 'root' folder needs to exist on the file system. You can use a path in the
To achieve what you describe in this ticket, to make sure a folder is created, we propose to introduce a new attribute for the LocalFileSystemPipe called 'createRootFolder', assuming the Frank instance has the correct access rights to do this. This way, this can't be an accidental side effect but makes it a conscious choice by the user. |
❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
We have a
LocalFileSystemPipe
with actionwrite
and createFolder set totrue
. The foldertempFiles
does not exist yet and I expect that the pipe will create the folder, however this does not happen, the pipe gives the following exception:Configuration
Environment
The text was updated successfully, but these errors were encountered: