Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the dialog element to display images #210

Open
jahirfiquitiva opened this issue Jan 15, 2024 · 2 comments
Open

Use the dialog element to display images #210

jahirfiquitiva opened this issue Jan 15, 2024 · 2 comments

Comments

@jahirfiquitiva
Copy link

I like the approach used by react-medium-image-zoom where it uses the dialog html element.

Implementation

This is the code that react-medium-image-zoom uses:

Shot 2024-01-15 at 14 51 27@2x

@francoischalifour
Copy link
Owner

That's nice, indeed! This is more accessible.

Would you like to open a pull request?

@jahirfiquitiva
Copy link
Author

@francoischalifour I may try, but can't promise 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants