Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convoy is not compatible with Redis Sentinel #1842

Open
itek09 opened this issue Nov 21, 2023 · 2 comments
Open

Convoy is not compatible with Redis Sentinel #1842

itek09 opened this issue Nov 21, 2023 · 2 comments
Assignees

Comments

@itek09
Copy link

itek09 commented Nov 21, 2023

Hello everyone.

Right now, I'm deploying Convoy using the official Helm Chart and I tried to use Redis Sentinel to have HA on it, but seems that Convoy is not compatible (even if the Chart suggest 'redis-sentinel' as a valid schema)

If you try to use that schema, the app gives you the next error:

{"level":"info","msg":"convoy.json not detected, will look for env vars or cli args","time":"2023-11-20 13:42:14"}
Error: redis: invalid URL scheme: redis-sentinel
time="2023-11-20T13:42:14Z" level=fatal msg="redis: invalid URL scheme: redis-sentinel"

Would be nice to allow that URL scheme to be able to use Sentinel.

Many thanks!

@jirevwe jirevwe self-assigned this Nov 21, 2023
@jirevwe
Copy link
Collaborator

jirevwe commented Nov 21, 2023

Hey @itek09,

I take full responsibility for this. This is on our roadmap and while we (read I) were adding cluster support, it skipped my mind to add sentinel support, but I did have in mind to add it while I was updating the helm charts. I'll update this issue with the PR that adds it.

@itek09
Copy link
Author

itek09 commented Nov 21, 2023

Many thanks! I will keep the issue on track as it would be a nice feature.

Thanks for the fast reply ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants