Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use pull_request_target #2141

Closed
tomek0123456789 opened this issue May 20, 2024 · 1 comment
Closed

Update CI to use pull_request_target #2141

tomek0123456789 opened this issue May 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tomek0123456789
Copy link
Collaborator

tomek0123456789 commented May 20, 2024

Which component is your feature related to?

Forge, Cast

Feature Request

Right now, when an external contributor wants to open a PR from a fork and we approve the CI run, the secrets we're using in tests aren't available to that run (GitHub security reasons).

  • Update CI to fix secret fetching
  • Additionally, update documentation with information that external contributors need to set secrets in their fork repository
@github-actions github-actions bot added the new label May 20, 2024
@tomek0123456789 tomek0123456789 added the bug Something isn't working label May 20, 2024
@tomek0123456789
Copy link
Collaborator Author

Closing since we are reverting the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant