Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue With Twitter Auth on Mobile #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Issue With Twitter Auth on Mobile #14

wants to merge 1 commit into from

Conversation

solarsoft0
Copy link

No description provided.

@yomexzo
Copy link
Contributor

yomexzo commented Oct 19, 2017

@okanlawonema, kindly share how to replicate the issue. Possibly with screenshots.

Thanks!

@yomexzo yomexzo requested a review from walez October 19, 2017 08:52
walez
walez reviewed Oct 19, 2017
View reviewed changes
Copy link
Member

@walez walez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A full page redirect is definitely better on a mobile device compared to the current popup approach, Will need to build and test locally to ensure it is working as expected.

@solarsoft0
Copy link
Author

solarsoft0 commented Oct 20, 2017 via email

@ovac
Copy link

ovac commented Feb 24, 2018

Please merge this fix. Signup with twitter isn't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walez walez walez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solarsoft0 @yomexzo @ovac @walez