Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nigeria E.164 Landline Numbers Error #483

Open
salami-dev opened this issue Feb 5, 2023 · 12 comments
Open

Nigeria E.164 Landline Numbers Error #483

salami-dev opened this issue Feb 5, 2023 · 12 comments

Comments

@salami-dev
Copy link
Contributor

Describe the bug
Trying to create a Nigerian E.164 Landline number on the Fonoster Console throws this error "Invalid phone number, please enter a valid phone number with E.164 format (e.g. +17853178070)"

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://console.fonoster.io/network/numbers'
  2. Click on the '+' button
  3. Select Phone Numbers
  4. In the 'E.164 Number' field, select country as Nigeria (+234)
  5. Type '12802500' after the +234 Prefix
  6. See error
  7. Try to bypass form validation
  8. Submit number to API
  9. See error

Expected behavior
Should be able to add a Nigerian E.164 Landline Number to Phone Numbers

Screenshots
image

System information (please complete the following):

  • Chrome Browser on Windows
@YSternlicht
Copy link

Had same issue when trying from UK. Number was similar to +447761444669

@psanders
Copy link
Member

@efraa any ideas about this issue?

@oracle-of-me
Copy link

We had the same issue. The problem is the generated request.

grafik

When you look at the request send, its seems to miss the "+" sign. When you add it manually and resend the request you can add numbers.

grafik

@efraa
Copy link
Contributor

efraa commented Mar 23, 2023

Hi @salami-dev,

Thanks for taking the time to try Fonoster. I will be evaluating this issue and will give updates on it no later than next Monday.

@efraa
Copy link
Contributor

efraa commented Mar 23, 2023

Hi @salami-dev,

We found part of the problem and it comes from the library we are using to validate the numbers, it seems that Nigerian numbers are up to 11 digits long but the lib assumes they should be 10 digits.

Check: https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L1266

We will open an issue for this and next week we will patch the node_modules if necessary.

@efraa
Copy link
Contributor

efraa commented Mar 23, 2023

Follow AfterShip/phone#349

@salami-dev
Copy link
Contributor Author

Hi @efraa

Thanks for diagnosing the issue.

Nigerian mobile numbers are 11 digits long.

Landlines are generally 8 - 9 digits, ex: 012802500

@psanders
Copy link
Member

psanders commented Apr 2, 2023

@salami-dev

We added support for Nigerian phone numbers.

Would you test configuring your number and let us know?

@salami-dev
Copy link
Contributor Author

Hi @psanders

Still unable to add from the fonoster console.

image
image

@luzpaz
Copy link

luzpaz commented May 17, 2023

Any updates?

@MRakox
Copy link

MRakox commented Jun 24, 2023

Same issue with French numbers (starting with +33), except I'm able to add them on the dashboard but they don't work with the node SDK.

Further informations :
I'm trying to make outbound calls with the SDK but I'm getting an error saying the "from" value isn't a valid e164 number (but it's the exact same as the one registered on the dashboard)

@psanders
Copy link
Member

@MRakox, thank you for reporting this issue. I will work on finding a solution as soon as I am able to allocate some time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants