Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Submenu arrow is positioned wrongly #3126

Open
mvorisek opened this issue Nov 21, 2024 · 3 comments
Open

[Dropdown] Submenu arrow is positioned wrongly #3126

mvorisek opened this issue Nov 21, 2024 · 3 comments
Labels
type/usage Any support issues asking for help

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Nov 21, 2024 •
edited
Loading

Bug Report

Steps to reproduce

  1. open https://ui.atk4.org/demos/basic/menu.php
  2. click "Sub-menu"
  3. notice the arrow (as screenshotted below) is positioned wrongly

not sure if related with #3123

Expected result

The dropdown arrow in sub menu item is expected to be aligned to the middle verticaly.

Actual result

image

Version

v2.9.3
@mvorisek mvorisek added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Nov 21, 2024
@lubber-de
Copy link
Member

Place the dropdown icon before the text in DOM to fix this.
See
dropdownicon_first

@lubber-de lubber-de added type/usage Any support issues asking for help and removed type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Nov 21, 2024
@mvorisek
Copy link
Contributor Author

That breaks the 1st level arrow/icon then:

image

(it is generated with the same template - https://github.com/atk4/ui/blob/5.2.0/template/submenu.html#L3 )

@lubber-de
Copy link
Member

lubber-de commented Nov 21, 2024 •
edited
Loading

But the first icon is the dropdown item itself, while all sub menu items should only be items containing another menu, not another dropdown items, so they should not share the same template.
Thats why i also removed the "ui dropdown" class from the sub menu item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/usage Any support issues asking for help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvorisek @lubber-de