Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row-level skipping when error occurs to all classes in the sources folder #524

Open
NealHumphrey opened this issue Sep 7, 2017 · 0 comments

Comments

@NealHumphrey
Copy link
Collaborator

When processing a data source, we want to skip one row if it fails to process for some reason, and instead continue with the next row. If we are not in debug mode (i.e. in production), we should log the error and continue. IF we are in debug mode, the exception should be re-raised.

An implementation of this was done for the base_project 'create_project_subsidy_csv' method, where we try to decode the address for each row. All of the 'sources' classes also now have a 'debug' flag in their init method. We should use this flag in the data processing step to properly handle exceptions as they occur so that one errant data source does not crash the whole data processing step.

The example to build off is in a pending commit, to be put into PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant