fix marshmallow-enum bug #1746
Merged
fix marshmallow-enum bug #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
This reverts commit 7d92b0f. Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
eapolinario
approved these changes
Jul 17, 2023
eapolinario
added a commit
that referenced
this pull request
Jul 18, 2023
* fix marchmallow-enum bug Signed-off-by: Niels Bantilan <[email protected]> * Remove constraints in requirements.in Signed-off-by: eduardo apolinario <[email protected]> * Fix test_dataclass_transformer Signed-off-by: eduardo apolinario <[email protected]> * Remove more dev dependencies Signed-off-by: eduardo apolinario <[email protected]> * Revert "Fix test_dataclass_transformer" This reverts commit 7d92b0f. Signed-off-by: eduardo apolinario <[email protected]> * Set upper bound ot dataclasses-json Signed-off-by: eduardo apolinario <[email protected]> * Set pyyaml version to 5.4.1 Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Closed
2 tasks
This was referenced Jul 18, 2023
eapolinario
added a commit
that referenced
this pull request
Jul 19, 2023
* fix marshmallow-enum bug (#1746) * fix marchmallow-enum bug Signed-off-by: Niels Bantilan <[email protected]> * Remove constraints in requirements.in Signed-off-by: eduardo apolinario <[email protected]> * Fix test_dataclass_transformer Signed-off-by: eduardo apolinario <[email protected]> * Remove more dev dependencies Signed-off-by: eduardo apolinario <[email protected]> * Revert "Fix test_dataclass_transformer" This reverts commit 7d92b0f. Signed-off-by: eduardo apolinario <[email protected]> * Set upper bound ot dataclasses-json Signed-off-by: eduardo apolinario <[email protected]> * Set pyyaml version to 5.4.1 Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> * Do not use latest tag in images Signed-off-by: eduardo apolinario <[email protected]> * Linting and replace pyyaml Signed-off-by: eduardo apolinario <[email protected]> * Regenerate doc-requirements Signed-off-by: eduardo apolinario <[email protected]> * Bring .readthedocs.yml back Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: Niels Bantilan <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jul 28, 2023
Signed-off-by: eduardo apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jul 28, 2023
Signed-off-by: eduardo apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jul 28, 2023
* gate grpc to <1.53.1 Signed-off-by: Yee Hing Tong <[email protected]> * pyyaml gate as well Signed-off-by: Yee Hing Tong <[email protected]> * Fail CI tests faster Signed-off-by: eduardo apolinario <[email protected]> * Bring #1746 as well Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jul 28, 2023
* Fail CI tests faster Signed-off-by: eduardo apolinario <[email protected]> * gate grpcio and pyyaml Signed-off-by: Yee Hing Tong <[email protected]> * Bring #1746 as well Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
* fix marchmallow-enum bug Signed-off-by: Niels Bantilan <[email protected]> * Remove constraints in requirements.in Signed-off-by: eduardo apolinario <[email protected]> * Fix test_dataclass_transformer Signed-off-by: eduardo apolinario <[email protected]> * Remove more dev dependencies Signed-off-by: eduardo apolinario <[email protected]> * Revert "Fix test_dataclass_transformer" This reverts commit 7d92b0f. Signed-off-by: eduardo apolinario <[email protected]> * Set upper bound ot dataclasses-json Signed-off-by: eduardo apolinario <[email protected]> * Set pyyaml version to 5.4.1 Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
|
@eapolinario Do you remember what needs to be done to remove the dataclasses-json upper bound introduced in d64f35b034ac728dbb27febcad017e1f9685ff5f? It looks like If it was just issues with |
@fellhorn yes, please do it, thanks |
It seems to go deeper and there is an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Installing flytekit==1.8.0 in a fresh environment gives a module not found error
Type
Are all requirements met?
Complete description
Error:
Tracking Issue
NA
Follow-up issue
NA