Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo sandbox] Add env vars to plugin config #6072

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Dec 2, 2024

What changes were proposed in this pull request?

This adds two environment variables to the sandbox config FLYTE_PLATFORM_URL and FLYTE_PLATFORM_INSECURE so that these are injected into pods launched by propeller. These env vars indicate to flytekit that the system is running internally within a sandbox, and how to reach out to the demo sandbox control plane.

How was this patch tested?

Locally by building a sandbox, and registering/running eager tasks against it.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title add env vars [demo sandbox] Add env vars to plugin config Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.10%. Comparing base (92f8abb) to head (c6eb585).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6072   +/-   ##
=======================================
  Coverage   37.10%   37.10%           
=======================================
  Files        1318     1318           
  Lines      132331   132331           
=======================================
  Hits        49100    49100           
  Misses      78959    78959           
  Partials     4272     4272           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit ba331fd into master Dec 3, 2024
57 checks passed
@wild-endeavor wild-endeavor deleted the sandbox-env-vars branch December 3, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants