Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeName template var and update doc #6088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ketian-indeed
Copy link

@ketian-indeed ketian-indeed commented Dec 6, 2024

Tracking issue

Closes #6086

Why are the changes needed?

See #6086 for more details.

What changes were proposed in this pull request?

  1. added a new template variable {{ .nodeName }} that will return the pod's spec.nodeName;
  2. also updated the doc accordingly.

How was this patch tested?

Unit tests added.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4939

Docs link

Copy link

welcome bot commented Dec 6, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@ketian-indeed
Copy link
Author

A friendly bump @ppiegaze @eapolinario 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hostname v.s. nodeName in logging link template
2 participants