Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytekit/eager] Correctly pipe through serialization settings #6070

Open
2 tasks done
wild-endeavor opened this issue Dec 2, 2024 · 0 comments
Open
2 tasks done
Labels
backlogged For internal use. Reserved for contributor team workflow. flytekit FlyteKit Python related issue

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Dec 2, 2024

Describe the issue

When a local task is being run through eager, the FlyteRemote instance will register it if it can't find the task, but the serialization settings that are used are not the same as the ones stored in the eager task's transport. This will probably lead to subtle bugs. We should amend remote's registration to handle things correctly.

What if we do not do this?

Subtle bugs will come up as eager tries to register new tasks.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added housekeeping Issues that help maintain flyte and keep it tech-debt free flytekit FlyteKit Python related issue backlogged For internal use. Reserved for contributor team workflow. and removed housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

1 participant