Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytekit/eager] Move the type engine invocation to the worker itself #6069

Open
2 tasks done
wild-endeavor opened this issue Dec 2, 2024 · 0 comments
Open
2 tasks done
Labels
backlogged For internal use. Reserved for contributor team workflow. flytekit FlyteKit Python related issue

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Dec 2, 2024

Describe the issue

Eager tasks kick off other Flyte entities when it runs against a Flyte backend. These executions need inputs in the form of Flyte literals of course. The translation of Python native values into these Flyte literals is currently being done by a FlyteRemote instance. This is okay for now but it's not ideal. The reason is that these input values form part of the hash that's used to consistently name downstream executions. We should hash the Flyte literal value to be most accurate, rather than the Python value.

What if we do not do this?

Consistent hashing of execution names is suboptimal and may lead to bugs down the road.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added housekeeping Issues that help maintain flyte and keep it tech-debt free flytekit FlyteKit Python related issue backlogged For internal use. Reserved for contributor team workflow. and removed housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

1 participant