Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep flight number set even if already taken #8656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BenJuan26
Copy link
Contributor

@BenJuan26 BenJuan26 commented May 17, 2024

Fixes #8650

Summary of Changes

Set the flight number in the FMC and the ATSU regardless of whether it's already taken. This has the benefit of setting the flight number instantly, instead of waiting to hear back from the API. The check is still made, and if the flight number is taken, the FLT NBR IN USE message is received and displayed by the ATSU.

Not yet tested: the effect of having a duplicate flight number during TELEX operations.

Screenshots (if necessary)

Starting the init req from the FCU. Note that no message is displayed in the FCU. A received message can be seen in the ATSU. The FLT NBR IN USE message is in the scratchpad, and the flight number is populated in the AOC.

2024-05-21.18-22-06-converted.mp4

I don't know if this is expected, but starting the request from the ATSU does not populate anything in the FCU, unlike the reverse.

atsu-init.mp4

Not necessarily related to this PR, but since it was brought up, I can confirm that the ATSU is reset completely after a flight is completed, including the flight number.

post-flight.mp4

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@2hwk 2hwk changed the title Keep flight number set even if already taken fix: keep flight number set even if already taken May 18, 2024
@BenJuan26 BenJuan26 marked this pull request as ready for review May 31, 2024 01:22
@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Quality Assurance
🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

INIT Page: field 'FLT NBR' not populated by Simbrief, and cannot be entered manually
1 participant