fix: keep flight number set even if already taken #8656
+10
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8650
Summary of Changes
Set the flight number in the FMC and the ATSU regardless of whether it's already taken. This has the benefit of setting the flight number instantly, instead of waiting to hear back from the API. The check is still made, and if the flight number is taken, the
FLT NBR IN USE
message is received and displayed by the ATSU.Not yet tested: the effect of having a duplicate flight number during TELEX operations.
Screenshots (if necessary)
Starting the init req from the FCU. Note that no message is displayed in the FCU. A received message can be seen in the ATSU. The
FLT NBR IN USE
message is in the scratchpad, and the flight number is populated in the AOC.2024-05-21.18-22-06-converted.mp4
I don't know if this is expected, but starting the request from the ATSU does not populate anything in the FCU, unlike the reverse.
atsu-init.mp4
Not necessarily related to this PR, but since it was brought up, I can confirm that the ATSU is reset completely after a flight is completed, including the flight number.
post-flight.mp4
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.