Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keptn Metrics Provider #1627

Closed
bacherfl opened this issue Apr 8, 2024 · 2 comments · Fixed by #1630 · May be fixed by bacherfl/flagger#1
Closed

Keptn Metrics Provider #1627

bacherfl opened this issue Apr 8, 2024 · 2 comments · Fixed by #1630 · May be fixed by bacherfl/flagger#1
Labels
kind/feature Feature request

Comments

@bacherfl
Copy link
Contributor

bacherfl commented Apr 8, 2024

Describe the feature

I would like to suggest the addition of a Keptn metrics provider to the list of already implemented providers.
I believe that, given the metric management capabilities of Keptn, would make this a valuable addition to Flagger and can benefit both projects. Being one of the Keptn maintainers, I would be happy to work on the implementation and documentation for this feature if this is something you would like to have added to Flagger :)

Proposed solution

I implemented a quick proof of concept in my fork of the flagger repo here.

The main difference to other providers in Flagger is that this one is using a Kubernetes client to interact with Keptn resources (KeptnMetrics and Analyses). Therefore, in addition to the code in keptn.go, the ClusterRole needs to be adapted to be able to access the required Keptn resources.
The provider supports the use of the following resources:

  • KeptnMetric: This resource represents the current value of a certain metric. The metric is retrieved by Keptn from one of the following data sources: prometheus, thanos, cortex, dynatrace, datadog.
  • Analysis: This Keptn resource can be used to calculate an overall score based multiple metric, and define a threshold for the overall score to be considered as successful. More information about this concept can be found in the Keptn Docs
@stefanprodan
Copy link
Member

Hi @bacherfl I'm happy to have this integration in Flagger. I see that the API version is at v1beta1, would you be able to help maintain the integration in Flagger going forward?

@stefanprodan stefanprodan added the kind/feature Feature request label Apr 8, 2024
@bacherfl
Copy link
Contributor Author

bacherfl commented Apr 8, 2024

Hi @stefanprodan, thanks for your quick response! Yes, I can certainly help to maintain the integration in case something needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
2 participants