Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent a few icons from being mistakenly read by screen readers #10524

Merged
merged 1 commit into from May 8, 2024
Merged

Prevent a few icons from being mistakenly read by screen readers #10524

merged 1 commit into from May 8, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented May 7, 2024 •
edited by atsansone

  • In the sidenav, set an empty alt content for screen readers for the arrows.
  • In the inline TOC, hide the icons themselves from screen readers and add explanatory titles to the surrounding spans, providing more details to all users.

Fixes #10536

@parlough parlough added the review.tech Awaiting Technical Review label May 7, 2024
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 57f0041):

https://flutter-docs-prod--pr10524-fix-screenreader-icon-fixes-p1y57emd.web.app

sfshaza2
sfshaza2 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atsansone
Copy link
Contributor

@parlough : Works as expected. I'll notify the Core a11y team.

@parlough parlough merged commit d40b964 into main May 8, 2024
9 checks passed
@parlough parlough deleted the fix/screenreader-icon-fixes branch May 8, 2024 18:02
@atsansone atsansone added st.RFM Ready to merge or land and removed review.tech Awaiting Technical Review labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@atsansone atsansone Awaiting requested review from atsansone atsansone is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@MaryaBelanger MaryaBelanger Awaiting requested review from MaryaBelanger MaryaBelanger is a code owner

Assignees

@atsansone atsansone

Labels
st.RFM Ready to merge or land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silence arrow icons in dropdown menus
4 participants
@parlough @flutter-website-bot @atsansone @sfshaza2