Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Jekyll include to liquidjs render where possible #10525

Open
parlough opened this issue May 7, 2024 · 0 comments
Open

Migrate Jekyll include to liquidjs render where possible #10525

parlough opened this issue May 7, 2024 · 0 comments
Assignees
@parlough
Labels
e1-hours Effort: < 8 hrs from.team Reported by Dash docs team member infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@parlough
Copy link
Member

parlough commented May 7, 2024

The include syntax we're using is supported as a fallback for migration, and render is the appropriate replacement tag. Its included content doesn't inherit its parents scope, reducing the chance of mistakes.
@parlough parlough added infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs from.team Reported by Dash docs team member labels May 7, 2024
@parlough parlough self-assigned this May 7, 2024
@parlough parlough mentioned this issue May 7, 2024
Merged
sfshaza2 pushed a commit that referenced this issue May 8, 2024
@parlough
Migrate app-figure.md includes to render (#10526)
e73c3fe 
Contributes to #10525 by
migrating all usages of `app-figure.md` to the newer `render` syntax
instead of `include`, for improved encapsulation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e1-hours Effort: < 8 hrs from.team Reported by Dash docs team member infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parlough