Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-to-app sample that uses flutter build macos-framework #1300

Open
jmagman opened this issue Jun 3, 2022 · 10 comments
Open

Add add-to-app sample that uses flutter build macos-framework #1300

jmagman opened this issue Jun 3, 2022 · 10 comments
Labels

Comments

@jmagman
Copy link
Member

jmagman commented Jun 3, 2022

flutter build macos-framework is available in master, but only works from normal flutter created apps, not -t module. Add a sample that shows flutter build macos-framework and flutter build ios-framework from a normal app (not module)

See flutter/flutter#104866 and flutter/flutter#105242.

@domesticmouse
Copy link
Contributor

@jmagman Any ideas when this will show up on beta?

@jmagman jmagman self-assigned this Jun 4, 2022
@jmagman
Copy link
Member Author

jmagman commented Jun 4, 2022

Not sure what the beta schedule is. I need a few engine changes too, I'll try to get that in next week.
I assigned this to myself, I have a prototype working.

@domesticmouse
Copy link
Contributor

Sounds good. To land a sample that only works in beta will require adding it to the beta CI and adding it commented out to the stable CI. I'm happy to own the AI to enable it with the next stable release.

@bkytes
Copy link

bkytes commented Jan 31, 2023

Is the add-to-app sample available? It will be really helpful if you can share it.

@domesticmouse
Copy link
Contributor

Is the add-to-app sample available? It will be really helpful if you can share it.

Have a look at the code under add_to_app.

@jmagman
Copy link
Member Author

jmagman commented Feb 1, 2023

The request would be to add a macOS sample version under https://github.com/flutter/samples/tree/main/add_to_app/prebuilt_module

@bkytes

This comment was marked as duplicate.

@jmagman

This comment was marked as duplicate.

@SharanPadmanabhan
Copy link

Any updates on the add-to-app sample and documentation for macOS?

@jmagman jmagman removed their assignment Apr 12, 2023
@jmagman
Copy link
Member Author

jmagman commented Apr 12, 2023

No update, but we take pull requests if you want to try adding it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants