Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router] Improve logging of routing tree (full paths) in DEBUG CONSOLE #148121

Closed
hashirshoaeb opened this issue May 10, 2024 · 2 comments · Fixed by flutter/packages#6714
Closed

[go_router] Improve logging of routing tree (full paths) in DEBUG CONSOLE #148121

hashirshoaeb opened this issue May 10, 2024 · 2 comments · Fixed by flutter/packages#6714
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: go_router The go_router package package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version team-go_router Owned by Go Router team

Comments

@hashirshoaeb
Copy link

hashirshoaeb commented May 10, 2024 •
edited

Currently routes are printed like this:
Screenshot 2024-05-10 at 10 55 51 AM

Problems

  • The => does not add any value
  • It does not explain shell routes

Proposal

Screenshot 2024-05-10 at 10 58 17 AM

  • | , ├─ └─ Improves the readability of tree/branches
  • Explains shell route in the tree
  • (Bonus) Displays Widget name, to whom it is routing to.

If the team agrees, I can create a pull request for this.

Related issues: #120382
@anwaar-siddiqi-blocship

This comment was marked as off-topic.

Sign in to view
@darshankawar darshankawar added the in triage Presently being triaged by the triage team label May 10, 2024
@darshankawar
Copy link
Member

If the team agrees, I can create a pull request for this.

Feel free to submit PR @hashirshoaeb

@darshankawar darshankawar added c: new feature Nothing broken; request for a new capability package flutter/packages repository. See also p: labels. c: proposal A detailed proposal for a change to Flutter p: go_router The go_router package team-go_router Owned by Go Router team and removed in triage Presently being triaged by the triage team labels May 10, 2024
@hashirshoaeb hashirshoaeb mentioned this issue May 12, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 21, 2024
@hashirshoaeb
[go_router] New feature improve debug full path (#6714)
b1ffd1e 
This PR fixes flutter/flutter#148121

- Replaced `=>` with `| `, `��` and `�� ` to improve readability
- It prints the Widget name for easy referencing
- Shell routes does not have their own paths for it is presented as ` (Shell route)` in the tree
- Prints the widget name of the routes it is building.
@darshankawar darshankawar added the r: fixed Issue is closed as already fixed in a newer version label May 22, 2024
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this issue May 22, 2024
@hashirshoaeb @TecHaxter
[go_router] New feature improve debug full path (flutter#6714)
eeaf06e 
This PR fixes flutter/flutter#148121

- Replaced `=>` with `| `, `��` and `�� ` to improve readability
- It prints the Widget name for easy referencing
- Shell routes does not have their own paths for it is presented as ` (Shell route)` in the tree
- Prints the widget name of the routes it is building.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: go_router The go_router package package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version team-go_router Owned by Go Router team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[go_router] New feature improve debug full path hashirshoaeb/packages
3 participants
@hashirshoaeb @darshankawar @anwaar-siddiqi-blocship