Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dependabot groups in packages repo #148098

Open
jmagman opened this issue May 9, 2024 · 4 comments
Open

Implement dependabot groups in packages repo #148098

jmagman opened this issue May 9, 2024 · 4 comments
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@jmagman
Copy link
Member

jmagman commented May 9, 2024

Dependabot now supports groups to update multiple packages in the same PR.
https://github.com/flutter/packages/blob/main/.github/dependabot.yml

Grouped version updates for Dependabot are generally available
Docs for groups

Ideally it would mean all the, say, gradle updates could happen in 1 PR, instead of 1 PR per package:
flutter/packages#6661
flutter/packages#6662
flutter/packages#6663
flutter/packages#6665
flutter/packages#6667
flutter/packages#6669

This would reduce the number of incoming commits to the packages repo, and reduce the review burden for keeping dependencies up-to-date.

@jmagman jmagman added the package flutter/packages repository. See also p: labels. label May 9, 2024
@jmagman
Copy link
Member Author

jmagman commented May 9, 2024

This will probably be easier for the packages repo when multi-directory becomes stable:
https://github.blog/changelog/2024-04-29-dependabot-multi-directory-configuration-public-beta-now-available/

@jmagman
Copy link
Member Author

jmagman commented May 9, 2024

cc @stuartmorgan

@darshankawar darshankawar added in triage Presently being triaged by the triage team team-ecosystem Owned by Ecosystem team and removed in triage Presently being triaged by the triage team labels May 10, 2024
@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. P2 Important issues not at the top of the work list triaged-ecosystem Triaged by Ecosystem team labels May 14, 2024
@stuartmorgan
Copy link
Contributor

/cc @reidbaker as well; the Android team should weigh in on which things it makes sense to batch. Some updates require other package-level changes, and in those cases batching could make things much harder to get landed.

@reidbaker
Copy link
Contributor

FWIW I think Gradle updates can be batched as can Kotlin updates.
AGP updates require manual effort most of the time so while I would like to say they cant be batched the reality is it doesnt matter because we will have to manually update everything anyway.
I dont think we have dependabot setup for android versions but compileSdkVersion could likely also be batched.

@gmackall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

4 participants