Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the DevTools flame chart to snap to the selected tree branch #8533

Open
kenzieschmoll opened this issue Nov 19, 2024 · 0 comments
Open
Labels
cpu profiler flame_chart P2 important to work on, but not at the top of the work list.

Comments

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Nov 19, 2024

The DevTools flame chart currently supports W-A-S-D keys to zoom and pan. Some flame chart implementations, like Perfetto's CPU flame chart, do not support these gestures. Instead, clicking on a stack frame will "snap" the chart to that specific branch of the tree. From the selected node up, all stack frames are rendered as single-parent-single-child relationships, and then the selected nodes children are rendered as normal. To "zoom out" or navigate up the tree, you can select once of the currently selected node's ancestors.

Screenshot 2024-11-19 at 2 07 01 PM _perfetto's CPU flame chart_

This would help some of the performance issues we have with the current CPU flame chart (e.g. #3876) and also simplify the code. This also would make the experience similar to other CPU flame chart tools users are used to using.

@kenzieschmoll kenzieschmoll added cpu profiler flame_chart P2 important to work on, but not at the top of the work list. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu profiler flame_chart P2 important to work on, but not at the top of the work list.
Projects
None yet
Development

No branches or pull requests

1 participant