-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use toml_edit instead of custom templating #1064
Labels
Comments
I'll work on this one 👍 |
github-merge-queue bot
pushed a commit
that referenced
this issue
May 22, 2024
…1333) ## Proposed Changes <!-- Describe the changes proposed in this pull request. --> <!-- Please provide links to any issue(s) which are expected to be resolved. --> This PR replaces uses of `String::replace` for editing and populating placeholders in `manifest.toml` to use `toml_edit` instead. Closes #1064. ## Release Notes N/A. <!-- Describe any user facing changes. Use "N/A" if not applicable. --> <!-- Many thanks! --> --------- Co-authored-by: Matthew Kenigsberg <[email protected]> Co-authored-by: Yannik Sander <[email protected]> Co-authored-by: Dan Carley <[email protected]> Co-authored-by: Alex Ameen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
flox init
, we're using a templatemanifest.toml
with identifiers to substitute. But if we're going to programmatically edit the file, we should just usetoml_edit
AC:
toml_edit
instead ofString::replace
inflox init
The text was updated successfully, but these errors were encountered: