Not Recognizing Moves in Collections

[BrandonDudek]

Expected Behavior

If an entry in a collection changes index in a collection, it should be reported as a move.

Actual Behavior

It is being reported as a replace.

Steps to Reproduce the Problem

JsonDiff.asJson(new ObjectMapper().valueToTree("[1, 2, 3]"), new ObjectMapper().valueToTree("[2, 1, 3]"));

Specifications

zjsonpatch 0.4.9
Java 1.8
jackson 2.9.7

[holograph]

To clarify, the result is [{"op":"replace","path":"","value":"[2, 1, 3]"}], which is a valid diff. As things stand we don't have a clear-cut strategy for diff generation (e.g. smallest, fastest-to-diff, fastest-to-apply...), so any decision is equally correct and idiotic :-)

[holograph]

I'm pretty comfortable closing this, unless anyone wants to pick up the discussion and try to formalize the different strategies and/or how to implement them...?

[BrandonDudek]

Since the current implementation is technically correct, but I would argue that what I was looking for would be "more correct".
Can this issue be changed from a Bug to a Feature Request? (There could even be a DiffFlags option.)

[holograph]

Oh I don't disagree (maybe just about the "level of correctness" assertion), and this can definitely by a worthwhile feature requests, but I think it bears defining a bit more carefully what these options are designed to accomplish.