Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aternative hide/show shortcut key to init settings #75

Open
sirmspencer opened this issue Oct 13, 2022 · 8 comments
Open

Add aternative hide/show shortcut key to init settings #75

sirmspencer opened this issue Oct 13, 2022 · 8 comments

Comments

@sirmspencer
Copy link

For example use ctrl+g.

ctrl+h is a common key for plug-ins. Allowing it to change would help with conflicts.

@flexsurfer
Copy link
Owner

i believe ctrl+h is used in re-frame-10x, do you know how it works for your team who works with it ?

@sirmspencer
Copy link
Author

Yes, ctrl+h is used in re-frame-10x. It means we cant load both plugins at the same time.

@sirmspencer
Copy link
Author

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

@sirmspencer sirmspencer changed the title Alternative hide/show shortcut key Add aternative hide/show shortcut key to init settings Oct 14, 2022
@sirmspencer
Copy link
Author

Updated title. I was thinking that it would be configurable and not just changed to a different key that could be a different conflict.

@flexsurfer
Copy link
Owner

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

but how it works for re-frame-10x then? do they have a solution ?

@sirmspencer
Copy link
Author

Apparently ctrl+h is also the history shortcut for firefox, so that interferes as well.

but how it works for re-frame-10x then? do they have a solution ?

Good question, they cannot use firefox, so they use chrome.

@sirmspencer
Copy link
Author

sirmspencer commented Oct 20, 2022

Are you ok with this option if I am able to create the PR?

@flexsurfer
Copy link
Owner

yes sure, PRs are welcomed , thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants