Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting files with suggested changes #47

Open
lmt-swallow opened this issue Aug 20, 2021 · 0 comments
Open

Overwriting files with suggested changes #47

lmt-swallow opened this issue Aug 20, 2021 · 0 comments
Labels
type: feature New feature

Comments

@lmt-swallow
Copy link
Member

lmt-swallow commented Aug 20, 2021

Problem

Currently Shisho reports suggested changes, but it can't replace files with the changes automatically.

Possible Solutions

It'd be great if we could overwrite files automatically with --overwrite option, for example.

# example
shisho find "len(:[X])" --lang=go --rewrite "len(f(:[X]))" --overwrite

Additional Notes

Shisho may suggest multiple changes for a single file when different rules match for a single file. This behaviour may cause some implementation challenges.

@lmt-swallow lmt-swallow added the type: feature New feature label Aug 20, 2021
@lmt-swallow lmt-swallow added this to To do in Core Features Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
Development

No branches or pull requests

1 participant