Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AMD by using UMD or similar #21

Open
alexlawrence opened this issue Jul 16, 2012 · 4 comments · May be fixed by #93
Open

Support for AMD by using UMD or similar #21

alexlawrence opened this issue Jul 16, 2012 · 4 comments · May be fixed by #93

Comments

@alexlawrence
Copy link

Could you maybe add support for AMD by using the Universal Module Definition which supports CommonJS/NodeJS, AMD and good old globals?

Read about it here: https://github.com/umdjs/umd
Example implementation: https://github.com/umdjs/umd/blob/master/returnExportsGlobal.js

Thank you
Regards
@jfhbrook
Copy link
Contributor

Wow, that looks gnarly. Browsers :(

I'd be open to a pull request that added support for browser-side amd, as long as it was also compatible with browserify.

@alexlawrence
Copy link
Author

It´s not that bad. Just remove all the comments (which no one reads anyways) and it´s only a few lines of code ;)

Okay, I will have a look at it. And try browserify.

Cheers

@konsumer konsumer linked a pull request Jan 25, 2015 that will close this issue
Open
@konsumer
Copy link

I did the browserify stuff properly (UMD-style) and added a demo in that last PR.

@konsumer
Copy link

It might make sense to add an empty gh-pages branch and put clientside.html in there as index.html, and the dist folder, then people can use gh-pages like a CDN, and you have a nice live demo, like so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Browser Stuff konsumer/revalidator
3 participants
@jfhbrook @konsumer @alexlawrence