Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fallback theming patch #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Backport fallback theming patch #17

wants to merge 1 commit into from

Conversation

jbruechert
Copy link
Collaborator

Should fix #16

@flathubbot
Copy link
Contributor

Started test build 34262

@flathubbot
Copy link
Contributor

Build 34262 failed

@travier
Copy link
Member

travier commented Apr 12, 2023

I fixed the pre-release filter in https://release-monitoring.org/project/261558/ to add ".80;.90"

@travier
Copy link
Member

travier commented Apr 12, 2023

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.kde.audiotube.

@flathubbot
Copy link
Contributor

Started test build 34329

@flathubbot
Copy link
Contributor

Build 34329 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/16966/org.kde.audiotube.flatpakref

@jbruechert
Copy link
Collaborator Author

@travier Thank you!

@travier travier mentioned this pull request Apr 12, 2023
Open
@razzeee
Copy link
Member

razzeee commented Apr 12, 2023

It seems to just crash, not sure if I broke something

❯ flatpak run org.kde.audiotube
QSocketNotifier: Can only be used with threads started with QThread
asyncdatabase: Checking whether migration "2022-05-20-194850_init" is already applied
asyncdatabase: … yes
asyncdatabase: Migrations finished
qrc:/SearchWithDropdown.qml:225:13: QML ScrollView: ScrollView only supports Flickable types as its contentItem
asyncdatabase: Running "select * from played_songs natural join songs order by plays desc limit 10"
asyncdatabase: Running "select * from favourites natural join songs order by favourites.rowid desc"
asyncdatabase: Running "select distinct (search_query) from searches order by search_id desc"
asyncdatabase: Running "select * from played_songs natural join songs"
file:///usr/lib/qml/QtQuick/Controls.2/org.kde.desktop/ScrollView.qml:44:9: QML WheelHandler: target must be a QQuickFlickable
qrc:/main.qml:75:13: QML ToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/SearchWithDropdown.qml:179:13: Unable to assign [undefined] to double
qrc:/main.qml:97:17: Unable to assign null to double
file:///usr/lib/qml/QtQuick/Controls.2/org.kde.desktop/ScrollView.qml:44:9: QML WheelHandler: target must be a QQuickFlickable
asyncdatabase: Running "select * from favourites natural join songs order by favourites.rowid desc"
asyncdatabase: Running "select * from played_songs natural join songs order by plays desc limit 10"
asyncdatabase: Running "select * from played_songs natural join songs"
asyncdatabase: Running "select distinct (search_query) from searches order by search_id desc"
file:///usr/lib/qml/QtQuick/Controls.2/org.kde.desktop/ScrollView.qml:44:9: QML WheelHandler: target must be a QQuickFlickable
asyncdatabase: Running "select * from favourites natural join songs order by favourites.rowid desc"
asyncdatabase: Running "select * from played_songs natural join songs order by plays desc limit 10"
asyncdatabase: Running "select * from played_songs natural join songs"
asyncdatabase: Running "select distinct (search_query) from searches order by search_id desc"

@travier
Copy link
Member

travier commented Apr 12, 2023

Not sure where the issue is. It runs for me. Maybe we need to have it pull the theme as well?

@jbruechert
Copy link
Collaborator Author

I think I know this bug, can you try whether flatpak run --env=QT_STYLE_OVERRIDE=Breeze org.kde.audiotube works?

@razzeee
Copy link
Member

razzeee commented Apr 12, 2023

That seems to work

@jbruechert
Copy link
Collaborator Author

jbruechert commented Apr 12, 2023 •
edited
Loading

Okay, then we have an AdwaitaQt bug most likely :(

EDIT: flatpak run --env=QT_STYLE_OVERRIDE=Adwaita org.kde.audiotube works fine on Plasma though

@Justinzobel
Copy link
Member

Ping. Does this crash still occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering seems broken
5 participants
@jbruechert @flathubbot @travier @razzeee @Justinzobel