Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu hidden/disable not identical to Item #201

Open
npetzall opened this issue Dec 16, 2021 · 0 comments
Open

Submenu hidden/disable not identical to Item #201

npetzall opened this issue Dec 16, 2021 · 0 comments

Comments

@npetzall
Copy link

Do you want to request a feature or report a bug?
Bug either Docs or Submenu component.

What is the current behavior?
handlerParams in Submenu doesn't include data property, which isn't even defined for Submenu.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:
https://fkhadra.github.io/react-contexify/disable-hide-submenu says it's the same as Item, but it's not.

const handlerParams = {
triggerEvent: triggerEvent as HandlerParamsEvent,
props: propsFromTrigger,
};

What is the expected behavior?
That I can provide data property to Submenu and it will be provided with the handlerParams to the BooleanPredicate just like Item.

OR

Clear documentation that this isn't supported for Submeny

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Version 5 of react-contexify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants