Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate misc spec items #118

Open
justindotpub opened this issue Mar 10, 2023 · 0 comments
Open

Validate misc spec items #118

justindotpub opened this issue Mar 10, 2023 · 0 comments

Comments

@justindotpub
Copy link
Contributor

justindotpub commented Mar 10, 2023

Make sure cold call graph is everything we plan on sending minus initial CIDs being pushed. Note this impacts the ability to create a bloom in parallel... need to know what is being sent before creating it so we don't set. And bloom doesn't allow unsetting, unless we use a different filter type that supports subtraction.

Confirm our want list / subgraph roots is just roots, not all CIDs. Noting this because it seemed pretty long in some tests, but likely just the nature of the randomly gen'd data.

Make sure we're adding each received block to our copy of the bloom.

ETA: 2024-02-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant