Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent multiple peers with same ID #137

Open
erhant opened this issue Oct 21, 2024 · 2 comments
Open

feat: prevent multiple peers with same ID #137

erhant opened this issue Oct 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@erhant
Copy link
Member

erhant commented Oct 21, 2024

No description provided.

@erhant
Copy link
Member Author

erhant commented Oct 21, 2024

libp2p/rust-libp2p#5641

@erhant erhant self-assigned this Oct 21, 2024
@erhant erhant added enhancement New feature or request invalid This doesn't seem right help wanted Extra attention is needed and removed invalid This doesn't seem right labels Oct 21, 2024
@erhant
Copy link
Member Author

erhant commented Oct 30, 2024

Looking at Kademlia DHT to see if our own peer address exists is NOT a solution, because self peerId is filtered out within the protocol level.

An alternative is to create a random ID that can be derived from the PeerId, and see if it exists in DHT. However, this should either be done with persistence (e.g. no TTL) or with TTL but in a periodic manner, nevertheless increasing the size of DHT.

A better option could be with a type of handshake method between the node and RPCs / Relay nodes so that the peer is ignored if it is already within the DHT as seen by an outsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant