Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on ascii text file difference in github action verification #74

Open
johodges opened this issue Aug 9, 2023 · 2 comments
Open

Comments

@johodges
Copy link
Collaborator

johodges commented Aug 9, 2023

Current github action verification does not check that the fds file does not change. It is pretty easy to check with the geom case, but the obst case may have minor variations in the XB. What are the team's thoughts on a hard check that the text files are the exact same versus allowing minor variations in the obst XB's?

@mcgratta
Copy link
Contributor

mcgratta commented Aug 9, 2023

I suggest we use the images as the final arbiter. It can be maddening to constantly swap in new references files for minor little differences.

@johodges
Copy link
Collaborator Author

johodges commented Aug 9, 2023

That is fine for testing the obst/geom and the fuel type/texture that is generated, but it won't test &TIME and &WIND lines which we are passing in as well. It is not critical to test these now. Once we are pulling in more detailed wind maps we may want to output a 2-D terrain slice with wind and render an image on that to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants