API: reconciled: false does not have precedence

[dreautall]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely a Firefly III issue, not me

Description

Dealing with changes to reconciled transactions using the API is a bit unexpected.

When editing a reconciled transaction via PUT api/v1/transactions/1234, as soon as the request has any "protected" field the API call will fail with an error that the transaction is reconciled. This is true even when reconciled: false is submitted in the request, or if the "protected" field value is not changed.

Debug information

Demo Page

Expected behaviour

1. When the request contains reconciled: false, it should un-reconcile the transaction and then proceed any changes made in the same request. Currently, a reocnciled: false request is needed, followed by a separate request to actually update any fields.
2. Even for reconciled transactions, if the request contains "restricted" fields such as amount, but that field is not changed compared to the stored value, the request should not fail but proceed to update any other fields if applicable.

Steps to reproduce

No response

Additional info

Looking at the web page, all fields seem to be filtered out of the update request when the transaction is reconciled to not fail according to the second point above. If this is the way you intend it to be, then consider this request only for the first point above (as this is quite annoying), and I'll implement something similar like the web page in the app!

[JC5]

I'll check it out, thanks!

[github-actions]

Hi there!

This is an automatic reply. Share and enjoy

This issue has been marked as being in triage. The root cause is not known yet, or the issue needs more investigation. You can help by sharing debug information (from /debug) if you also have this issue or when you haven't already done so.

Thank you for your contributions.

[JC5]

Assuming you want to update protected fields.

• If you submit "reconciled": true to any unreconciled transaction, that will be the last time you can edit it. After that, it will complain.
• Submitting "reconciled": false allows you to overrule this, and your updates will be saved. The transaction will be unreconciled as well.
• Even if you leave the value the same, Firefly III will complain about trying to update reconciled transactions. The validator can't check existing values, i have enough spaghetti code as it is.

[dreautall]

Even if you leave the value the same, Firefly III will complain about trying to update reconciled transactions. The validator can't check existing values, i have enough spaghetti code as it is.

Alright thank you, I'll add some code for this case in my app then to not re-submit unmodified values.