-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Auth: Provide an API to create/update users without unneeded API requests #1885
Comments
I found a few problems with this issue:
|
@lahirumaramba @prameshj I noticed you added the "help wanted" label. I'm more than happy to submit a PR for this, however we need to align on the proposal first. What are your thoughts? |
@lahirumaramba @prameshj didn't get a response so assuming that you were ok with my original proposal? I have drafted the PR accordingly, along with tests etc, it would be great if you can take a moment to check it 🙏🏼 . |
The
updateUser()
andcreateUser()
methods always perform two API requests under the hood: (1) the create/update request, and (2) a subsequentgetUser()
request.In latency-sensitive applications where the result of
getUser()
is not required, this means an extra un-needed sequential round-trip network request. This fact is not apparent from the API or documentation.Proposal
Add a second, optional parameter to
createUser()
andupdateUser()
called something likenoFetchUserRecord
which defaults tofalse
(existing behaviour). Iftrue
, thegetUser()
request will be skipped, and the function will returnPromise<void>
, avoiding the un-needed round-trip request.The text was updated successfully, but these errors were encountered: