Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Recursion status #693

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aristosMiliaressis
Copy link
Contributor

Description

I added the option -recursion-status to control what response codes cause recursion to happen, the main use case is to recurse on 403.

Also i added the option -acp to auto calibrate per path, so if a 403 path is recursed and and all subsequest requests also receive 403 they are not also recursed.

Fixes: #691

@aristosMiliaressis aristosMiliaressis changed the title Recursion status [FEATURE] Recursion status Jun 15, 2023
Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

After initial review there was just this one change request that I spotted.

pkg/ffuf/job.go Outdated
@@ -499,7 +505,7 @@ func (j *Job) handleGreedyRecursionJob(resp Response) {
// not been reached
func (j *Job) handleDefaultRecursionJob(resp Response) {
recUrl := resp.Request.Url + "/" + "FUZZ"
if (resp.Request.Url + "/") != resp.GetRedirectLocation(true) {
if (resp.Request.Url+"/") != resp.GetRedirectLocation(true) && resp.StatusCode >= 300 && resp.StatusCode < 400 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should honor the values in the new cli parameter for recursion-status here instead of hardcoded values between 300 and 400.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, i pushed the suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Recursion Status
2 participants