Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4 #24

Closed
wants to merge 1 commit into from
Closed

Fix #4 #24

wants to merge 1 commit into from

Conversation

Hacksore
Copy link

@Hacksore Hacksore commented Dec 3, 2023

ico seems to have a limit on max size but we can use a large png instead.

I even learned at a certain resolution that chrome wont event render images, see this example 💀.

test

this closes #4

Copy link

@PickleNik PickleNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markkhoo
Copy link

markkhoo commented Dec 4, 2023

LGTM

@Hacksore
Copy link
Author

Hacksore commented Feb 1, 2024

Warning

I NO LONGER CARE

@Hacksore Hacksore closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

favicon isn't over a GB
3 participants