Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language guide(s) for 3.0 #1376

Closed
2 of 3 tasks
Tracked by #2619 ...
lann opened this issue Aug 30, 2024 · 4 comments
Closed
2 of 3 tasks
Tracked by #2619 ...

Update language guide(s) for 3.0 #1376

lann opened this issue Aug 30, 2024 · 4 comments
Labels
spin-3.0 Changes arriving in Spin 3.0

Comments

@lann
Copy link
Contributor

lann commented Aug 30, 2024

Spin 3.0 is dropping support for uncomponentized modules, which impacts some language guides:

@vdice
Copy link
Member

vdice commented Oct 23, 2024

Shall we add a bullet to update manifest snippets throughout the language guide as well? The 3.0-related bit is to remove instances of application base config (ref #1394).

@vdice
Copy link
Member

vdice commented Oct 30, 2024

@lann what should we do for the Swift language guide at this time? As you've mentioned, Spin 3+ won't run the app (after I updated the example code/manifest locally):

$ spin up
Logging component stdio to ".spin/logs/"
Error: failed to resolve dependencies for component "hello"

Caused by:
   0: an error occurred when preparing dependencies
   1: This Wasm module appears to have been compiled with wasi-sdk version <19 which contains a critical memory safety bug. For more information, see: https://github.com/fermyon/spin/issues/2552

Do we keep the (updated) example and mention it only functions with Spin 2 and previous? Add a mention that compatibility with Spin 3 may arrive in Swift 6.0? (Any applicable links?)

@lann
Copy link
Contributor Author

lann commented Oct 31, 2024

Do we keep the (updated) example and mention it only functions with Spin 2 and previous? Add a mention that compatibility with Spin 3 may arrive in Swift 6.0?

Sounds reasonable to me!

(Any applicable links?)

No, iirc this is based on me digging around in the SwiftWasm code and seeing that 5.x uses a "bad" version of wasi-libc while 6.0 uses a "good" version.

@vdice
Copy link
Member

vdice commented Nov 4, 2024

We've addressed the main languages impacted by Spin 3.0, including updating manifests (bump to v2, remove base option). There are most likely many places where language guide updates are overdue per ecosystem advances, but we can track this elsewhere. Shall we close this one out @lann?

@lann lann closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spin-3.0 Changes arriving in Spin 3.0
Projects
None yet
Development

No branches or pull requests

2 participants