Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle button group #38

Closed
felix-bohlin opened this issue Nov 27, 2024 · 6 comments
Closed

toggle button group #38

felix-bohlin opened this issue Nov 27, 2024 · 6 comments
Milestone

Comments

@felix-bohlin
Copy link
Owner

felix-bohlin commented Nov 27, 2024

No description provided.

@felix-bohlin felix-bohlin converted this from a draft issue Nov 27, 2024
@felix-bohlin felix-bohlin added this to the 1.0 milestone Nov 27, 2024
@felix-bohlin felix-bohlin moved this from Important right now to In progress in open props ui Dec 4, 2024
@felix-bohlin felix-bohlin moved this from In progress to Alpha in open props ui Dec 6, 2024
@Deufel
Copy link
Contributor

Deufel commented Jan 10, 2025

Consider the tab focus of the toggle button group to use the border of the button instead of the content, Thoughts?
Screenshot 2025-01-10 at 12 56 31 PM
Screenshot 2025-01-10 at 12 57 29 PM

1 similar comment
@Deufel
Copy link
Contributor

Deufel commented Jan 10, 2025

Consider the tab focus of the toggle button group to use the border of the button instead of the content, Thoughts?
Screenshot 2025-01-10 at 12 56 31 PM
Screenshot 2025-01-10 at 12 57 29 PM

@felix-bohlin
Copy link
Owner Author

felix-bohlin commented Jan 11, 2025

Thanks for the feedback! ☺️ Is it recommended accessibility wise to do that?

Just so I understand, are you proposing the square variant over the other one? 🙃

@felix-bohlin felix-bohlin moved this from Not yet to In progress in open props ui Jan 13, 2025
@Deufel
Copy link
Contributor

Deufel commented Jan 13, 2025

Sorry for the vague comment...
I thought that the rounded variation looks better, I am not an expert with the accessibility recommendations :/. I was admittedly only looking at this from am aesthetic perspective.

I had a situation were I had a button-group next to a toggle-button-group and just was thinking that the tab focus on the button group (with the focus following the rounded border) looked nicer, Thanks

@felix-bohlin
Copy link
Owner Author

felix-bohlin commented Jan 13, 2025

Ah I see, good catch! I've done a new commit with fixes that should make the outline look the same. You can find the new styles here as usual. Did it solve it for you @Deufel ?

@Deufel
Copy link
Contributor

Deufel commented Jan 14, 2025

Following up on this; Yes. That fixed it! Thank you

@felix-bohlin felix-bohlin moved this from In progress to Done in open props ui Jan 14, 2025
@felix-bohlin felix-bohlin closed this as completed by moving to Done in open props ui Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants