Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with generated p-values #8

Open
bitona opened this issue Dec 4, 2019 · 4 comments
Open

problem with generated p-values #8

bitona opened this issue Dec 4, 2019 · 4 comments

Comments

@bitona
Copy link

bitona commented Dec 4, 2019

Hello,

I am using Jacks to analyse a CRISPR screen where i want to select positively enriched genes compared to a control.
Everything works very well in terms of beta scores, with a positive control getting the largest beta score as expected. But the p-values are the opposite of what i would expect, with our positive controls never getting low p-values.
I have used as control genes both the NEGv1.txt nonessential gene list you provide and also tried to use three control genes from the TKOv3 library we use. I encountered the same problem in both.
I was wondering if there was something i was missing or not using the right control genes ?

Best,
Anne

@lp2
Copy link

lp2 commented Dec 5, 2019 via email

@felicityallen
Copy link
Owner

felicityallen commented Dec 5, 2019 via email

@bitona
Copy link
Author

bitona commented Dec 6, 2019

Thank you for your answers!
Yes this is a positive selection screen. Following your advice, when i use genes with p-values equal to 1 i do obtain meaningful hits so it seems to work well (but lowering the threshold to 0.95 or even 0.99 seem to select a much higher number of genes that i suspect are false positives so i will stick to 1 for now).

Best,
Anne

@lp2
Copy link

lp2 commented Dec 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants