2139 add maxpy and mdot support #2141

prudhomm · 2023-07-14T15:35:13Z

Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes?
Have you successfully run the Feel++ testsuite with your changes locally?
Have you written Doxygen comments in your contribution ?

closes implement nirb framework for elliptic problems #1912
closes Reduce NIRB complexity #1950
closes use nirb approx in greedy algorithm #2038
closes test nirb convergence #2041
closes Fix NIRB execution #2125
closes add maxpy and mdot support to Vector class #2139

…into 1912-implement-nirb-tools [ci skip]

[ci skip]

the architecture is present but still bugs in it [ci skip]

[ci skip]

@alielarif

/cc @alielarif [skip feelpp, skip tests, skip toolboxes, skip mor]

#1912 [ci skip]

[ci skip]

now scripts Offline.py and Online.py are installed and can be loaded. The function implemented are used in test_nirb for now only offline has been refactored [ci skip]

…2041-test-nirb-convergence

[ci skip]

…implement nirb tools in feel++ #1912

…or test nirb convergence #2041

…2041-test-nirb-convergence

[ci skip]

thomas-saigre · 2023-07-16T14:49:21Z

@prudhomm It also seems that the wrapping has been broken : https://buildkite.com/feelpp/feelpp/builds/4980#01895eda-c34a-41c0-b040-e791c442f410/695-1122

@thomas-saigre

…ture /cc @thomas-saigre skip feelpp skip tests skip toolboxes skip mor #2139

[ci skip]

@prudhomm

add header to stl for conversion test not passing yet /cc @prudhomm [ci skip]

[ci skip]

@prudhomm

/cc @prudhomm [ci skip]

@prudhomm

convert by hand the feelpp._core.WorldsComm in a List[feelpp._core.WroldComm] [skip feelpp, skip toolboxes, skip mor, skip tests] /cc @prudhomm

@prudhomm

because the wrapping of add(List[float], List[vector]) messed it up /cc @prudhomm [skip feelpp, skip tests, skip mor, skip toolboxes]

thomas-saigre · 2023-08-05T15:39:34Z

python/pyfeelpp/feelpp/__init__.py.in

@@ -175,10 +175,11 @@ def functionSpace( mesh, space="Pch", order=1, worldscomm=None):
 """
 if worldscomm is None:
 worldscomm = Environment.worldsComm(1)
+ worldscomm_list = [worldcomm for worldcomm in worldscomm]


@prudhomm With the adding of the header to pybind11/stl.h, the constructor for spaces[key] was no longer waiting a feelpp._core.WorldsComm but a List[feelpp._core.WorldComm].
I found this workaround by converting it by hand to a Python list, but there may be a better way to do it...

#2139

thomas-saigre · 2023-08-05T15:43:38Z

python/pyfeelpp/feelpp/alg.cpp

@@ -276,7 +276,7 @@ PYBIND11_MODULE(_alg, m )
 .def( "addVector", static_cast<void ( Vector<double>::* )
 ( std::shared_ptr<Vector<double>> const& , std::shared_ptr<MatrixSparse<double>> const& )
 >( &Vector<double>::addVector ), "add the product of a MatrixSparse and a vector to this vector" )
- .def( "add", [](Vector<double> &v, double a, Vector<double> const& w){ v.add(a, w); }, "add a scalar*vector to this vector" )
+ .def( "addVector", [](Vector<double> &v, double a, Vector<double> const& w){ v.add(a, w); }, "add a scalar*vector to this vector" )


@prudhomm With the wrapping add(List[float] alphas, List[vector] vs) computing $u += \sum_i \alpha_i vs[i]$, the initial add(float alpha, vector v) computing $u += \alpha u$ was no longer included in the wrapped class.
A workaround I found is to rename this method to addVector so it can be wrapped correctly. Maybe there is another way to do it...

#2139

[ci skip]

- fix offline execution and refactor code with removing some loops - fix onlien execution : used the right number of basis functions #2139 [skip feelpp, skip toolboxes, skip mor, skip tests]

[skip feelpp, skip mor, skip tests, skip toolboxes]

prudhomm · 2023-08-22T10:52:25Z

@thomas-saigre I sync'ed with develop. there is still work to do in mor

[ci skip]

…eelpp into 2139-add-maxpy-and-mdot-support [ci skip]

[skip feelpp, skip tests]

github-actions · 2023-10-23T23:23:05Z

Stale pull request message

…-mdot-support

github-actions · 2023-12-08T23:23:11Z

Stale pull request message

…eelpp into 2139-add-maxpy-and-mdot-support

github-actions · 2024-01-26T23:23:02Z

Stale pull request message

thomas-saigre and others added 30 commits January 25, 2023 16:19

tiny fixes in test

8fdaf83

Merge branch '1912-implement-nirb-tools' of github.com:feelpp/feelpp …

0dc8b35

…into 1912-implement-nirb-tools [ci skip]

start work on greedy with nirb approximation

072ea78

[ci skip]

up greedy code #2038

c651a51

the architecture is present but still bugs in it [ci skip]

up greedy algorithm #2038

a24e86f

[ci skip]

add function getRectificationMatrix #1912

92674b0

/cc @alielarif [skip feelpp, skip tests, skip toolboxes, skip mor]

up forgotten modif in 92674b0

b546ada

#1912 [ci skip]

refactor nirb tests #2038

a7bd43d

[ci skip]

refactor nirbOffline script and tests

61c5a12

now scripts Offline.py and Online.py are installed and can be loaded. The function implemented are used in test_nirb for now only offline has been refactored [ci skip]

up wrapping in sampling

5c58306

get distinct sampling for test and train

0cd892e

rename file skip feelpp skip tests skip toolboxes skip mor

1123f3c

clean up file

6ef1c8c

Merge branch '2014-add-multiblock-2d-and-3d-use-case-generator' into …

034b7d5

…2041-test-nirb-convergence

fix greedy+rectificatio tests #2038

676f0c8

[ci skip]

Fix tests : add online tests #2038 #1912

b211a53

[ci skip]

refactor online #1912 #2038

fd84cc2

[ci skip]

remove rectification param from offline. test nirb convergence #2041 …

c42f00f

…implement nirb tools in feel++ #1912

test nirb perf in respect of rectif parameter.

6db279d

remove rectif param from offline

7116abb

up compare list of errors

f90fdf7

up file

609d260

up plot lsit of errors

dda98d0

create dir by one proc.

b3aaacf

add thermal bridge test. skip feelpp skip tests skip toolboxes skip m…

57781ca

…or test nirb convergence #2041

Merge branch '2014-add-multiblock-2d-and-3d-use-case-generator' into …

191e6c5

…2041-test-nirb-convergence

add function greedy step #2038

d705934

tiny fixes

7fa833a

[ci skip]

add class method to export basis function

c1121fd

[ci skip]

up printing infos. skip feelpp skip tests skip toolboxes skip mor

4eb6867

prudhomm and others added 7 commits July 16, 2023 23:19

include eigen.h to convert Eigen data structures to python data struc…

a2fa72c

…ture /cc @thomas-saigre skip feelpp skip tests skip toolboxes skip mor #2139

up test_alg #2139

2d63c33

[ci skip]

up test discr tests for mDot #2139

b75c52b

add header to stl for conversion test not passing yet /cc @prudhomm [ci skip]

use vectorized functions instead of loops #2139

a07023c

[ci skip]

add test for the addfunction takin float as parameter #2139

4315d04

/cc @prudhomm [ci skip]

attemp to fix bug induced by the adding of pybind/stl.h

71225bc

convert by hand the feelpp._core.WorldsComm in a List[feelpp._core.WroldComm] [skip feelpp, skip toolboxes, skip mor, skip tests] /cc @prudhomm

rename add(float, vector) -> addVector(float, vector)

c98ef41

because the wrapping of add(List[float], List[vector]) messed it up /cc @prudhomm [skip feelpp, skip tests, skip mor, skip toolboxes]

thomas-saigre reviewed Aug 5, 2023

View reviewed changes

thomas-saigre and others added 4 commits August 5, 2023 17:43

remove useless print

6435817

[ci skip]

fixes for nirb :

e4c630e

- fix offline execution and refactor code with removing some loops - fix onlien execution : used the right number of basis functions #2139 [skip feelpp, skip toolboxes, skip mor, skip tests]

fix time measurment

c6a78c8

[skip feelpp, skip mor, skip tests, skip toolboxes]

Merge branch 'develop' into 2139-add-maxpy-and-mdot-support

c033782

thomas-saigre added 3 commits August 24, 2023 15:01

tiny modifications for merge

fe0114a

[ci skip]

Merge branch '2139-add-maxpy-and-mdot-support' of github.com:feelpp/f…

fd73fa7

…eelpp into 2139-add-maxpy-and-mdot-support [ci skip]

fix s.sampling -> s.sample

d43f567

[skip feelpp, skip tests]

github-actions bot added the no-pr-activity label Oct 23, 2023

thomas-saigre removed the no-pr-activity label Oct 24, 2023

Merge remote-tracking branch 'origin/develop' into 2139-add-maxpy-and…

1630354

…-mdot-support

github-actions bot added the no-pr-activity label Dec 8, 2023

Merge branch 'develop' into 2139-add-maxpy-and-mdot-support

ca1001c

github-actions bot removed the no-pr-activity label Dec 11, 2023

Merge branch '2139-add-maxpy-and-mdot-support' of github.com:feelpp/f…

884d26f

…eelpp into 2139-add-maxpy-and-mdot-support

github-actions bot added the no-pr-activity label Jan 26, 2024

github-actions bot closed this Feb 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2139 add maxpy and mdot support #2141

2139 add maxpy and mdot support #2141

prudhomm commented Jul 14, 2023 •

edited

thomas-saigre commented Jul 16, 2023

thomas-saigre Aug 5, 2023

thomas-saigre Aug 5, 2023

prudhomm commented Aug 22, 2023

github-actions bot commented Oct 23, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Jan 26, 2024

2139 add maxpy and mdot support #2141

2139 add maxpy and mdot support #2141

Conversation

prudhomm commented Jul 14, 2023 • edited

thomas-saigre commented Jul 16, 2023

thomas-saigre Aug 5, 2023

Choose a reason for hiding this comment

thomas-saigre Aug 5, 2023

Choose a reason for hiding this comment

prudhomm commented Aug 22, 2023

github-actions bot commented Oct 23, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Jan 26, 2024

prudhomm commented Jul 14, 2023 •

edited